Fix describing concatenations in alternations #62646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was previously too aggressive in getting rid of concatenations in the comment rendering. We would end up flattening concatenations into alternations erroneously.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsI was previously too aggressive in getting rid of concatenations in the comment rendering. We would end up flattening concatenations into alternations erroneously.
|
joperezr
reviewed
Dec 10, 2021
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Show resolved
Hide resolved
joperezr
approved these changes
Dec 10, 2021
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
Minor question, but other than that Looks good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was previously too aggressive in getting rid of concatenations in the comment rendering. We would end up flattening concatenations into alternations erroneously.
cc: @joperezr