Bring over NativeAOT smoke tests #62763
Conversation
We'll probably want to spread these out to the appropriate categories (CoreMangLib, etc.) and enable them for non-NativeAOT scenarios eventually. For now, moving these as they were in runtimelab because being able to build them as a subtree (`build.sh tree nativeaot`) in one go makes things easy.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| #endif | ||
|
|
||
| #if !defined(__stdcall) | ||
| #ifndef TARGET_WINDOWS |
There was a problem hiding this comment.
I swear that I copy that from some place. I not that creative in C++ to think about such condition. Maybe this should be changed in other places as well.
There was a problem hiding this comment.
https://github.com/dotnet/runtime/pull/62763/files#diff-853460ee46510792e4ae93dd6307874a18b0265119a3a78d044d60fd74e13626R18 in PInvokeNative.cpp same construct
There was a problem hiding this comment.
Yeah, the one in PInvokeNative.cpp looks also wrong but it's not a build break on x86 (the one in this file was a build break because calling convention of the override doesn't match the base method since the macro turns __stdcall into nothing).
ghost
locked as resolved and limited conversation to collaborators
3 participants
We'll probably want to spread these out to the appropriate categories (CoreMangLib, etc.) and enable them for non-NativeAOT scenarios eventually. For now, moving these as they were in runtimelab because being able to build them as a subtree (
build.sh tree nativeaot) in one go makes things easy.