Skip to content

Fix logging initialization race (#616) #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janvorli merged 2 commits into from
Dec 9, 2019
Merged

Fix logging initialization race (#616) #634

janvorli merged 2 commits into from
Dec 9, 2019

Conversation

@SrivastavaAnubhav
Copy link
Contributor

@SrivastavaAnubhav SrivastavaAnubhav commented Dec 6, 2019 •
edited
Loading

Fixes #616

  • Make logging initialization thread-safe
  • Fix broken defines for InterlockedCompareExchangePointer and InterlockedExchangePointer

Anubhav Srivastava added 2 commits December 6, 2019 14:37
Make logging initialization thread-safe. Fix broken defines for Inter…
6825312 
…lockedCompareExchangePointer and InterlockedExchangePointer.
Add InitLogging back to log.h. Revert change to the defines in utilco…
3453f29 
…de.h. Move LogFileMutex initialization to InitializeLogging.
@janvorli janvorli added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 7, 2019
@janvorli janvorli added this to the 5.0 milestone Dec 7, 2019
janvorli
janvorli approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 7d49d20 into dotnet:master Dec 9, 2019
@SrivastavaAnubhav SrivastavaAnubhav deleted the threadsafe-logging branch December 9, 2019 17:50
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this pull request Mar 25, 2021
@MichalStrehovsky
Annotate a couple more marshal APIs (dotnet#678)
2c8ff60 
And add intrinsic handling. Fixes dotnet#634.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janvorli janvorli janvorli approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Crossgen2 parallelism triggered race

2 participants

@SrivastavaAnubhav @janvorli