Skip to content

global-build-job: Add missing closing paren to unbreak ci #63480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
radical wants to merge 1 commit into from
Closed

global-build-job: Add missing closing paren to unbreak ci #63480

radical wants to merge 1 commit into from

Conversation

@radical
Copy link
Member

@radical radical commented Jan 6, 2022

Typo got added in #63311

dotnet-linker-tests 1533580 / Pipeline Definition Validation
❌ /eng/pipelines/common/global-build-job.yml (Line: 83, Col: 9): Unclosed function: 'or'. Located at position 1 within expression: or( eq(parameters.runtimevariant, 'llvmaot'), eq(parameters.runtimevariant, 'llvmfullaot'). For more help, refer to go.microsoft.com/fwlink/?linkid=842996

@ghost
Copy link

ghost commented Jan 6, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@radical radical requested a review from naricc January 6, 2022 22:52
@ghost ghost assigned radical Jan 6, 2022
@radical radical requested review from lewing and steveisok January 6, 2022 22:52
@radical radical removed their assignment Jan 6, 2022
@tannergooding tannergooding mentioned this pull request Jan 6, 2022
Merged
@radical
Copy link
Member Author

radical commented Jan 7, 2022

Closing in favor of #63483 .

@radical radical closed this Jan 7, 2022
@radical radical deleted the fix-missing-paren branch January 7, 2022 00:10
@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@steveisok steveisok Awaiting requested review from steveisok

+1 more reviewer

@naricc naricc naricc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@radical @lewing @naricc