Skip to content

[mono][debugger] Fix step on ios when using interpreter #63515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaystg merged 3 commits into from
Jan 11, 2022
Merged

[mono][debugger] Fix step on ios when using interpreter #63515

thaystg merged 3 commits into from
Jan 11, 2022

Conversation

@thaystg
Copy link
Member

@thaystg thaystg commented Jan 7, 2022

On save_seq_points function we loop in this td->basic_blocks list, but this block was not being added so we could not step correctly on iOS.

@thaystg thaystg requested a review from vargaz as a code owner January 7, 2022 20:58
@ghost ghost assigned thaystg Jan 7, 2022
@ghost
Copy link

ghost commented Jan 7, 2022

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

On save_seq_points function we loop in this td->basic_blocks list, but this block was not being added so we could not step correctly on iOS.

Author: thaystg
Assignees: thaystg
Labels:

area-Codegen-Interpreter-mono
Milestone: -

BrzVlad
BrzVlad reviewed Jan 10, 2022
View reviewed changes
src/mono/mono/mini/interp/transform.c Outdated
}

static void
add_bb_to_basic_blocks(TransformData *td, InterpBasicBlock *bb)
Copy link
Member

@BrzVlad BrzVlad Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see the usefulness of this method

Copy link
Member Author

@thaystg thaystg Jan 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the function.

@marek-safar
Copy link
Contributor

marek-safar commented Jan 11, 2022

Should this be backported?

@thaystg
Copy link
Member Author

thaystg commented Jan 11, 2022 •
edited
Loading

Should this be backported?

I think so. I'm not sure if to 6.0 or to 6.0maui.

@marek-safar
Copy link
Contributor

marek-safar commented Jan 11, 2022

6.0maui at this point

@thaystg
Copy link
Member Author

thaystg commented Jan 11, 2022

/backport to release/6.0maui

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2022

Started backporting to release/6.0maui: https://github.com/dotnet/runtime/actions/runs/1682928588

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2022

@thaystg an error occurred while backporting to release/6.0maui, please check the run log for details!

Error: The specified backport target branch release/6.0maui wasn't found in the repo.

@thaystg
Copy link
Member Author

thaystg commented Jan 11, 2022

/backport to release/6.0-maui

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2022

Started backporting to release/6.0-maui: https://github.com/dotnet/runtime/actions/runs/1682945058

@github-actions github-actions bot mentioned this pull request Jan 11, 2022
Merged
@thaystg thaystg merged commit 59b55a2 into dotnet:main Jan 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BrzVlad BrzVlad BrzVlad approved these changes

@lewing lewing Awaiting requested review from lewing

@lambdageek lambdageek Awaiting requested review from lambdageek

@vargaz vargaz Awaiting requested review from vargaz

Assignees

@thaystg thaystg

Labels

area-Codegen-Interpreter-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thaystg @marek-safar @BrzVlad