Skip to content

Added OS and Bit Specific tags to accordingly .csproj files. #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivdiazsa merged 1 commit into from
Dec 13, 2019
Merged

Added OS and Bit Specific tags to accordingly .csproj files. #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/Interop/ArrayMarshalling/ByValArray/MarshalArrayByValTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,7 @@
<ProjectReference Include="$(SourceDir)Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" />
<ProjectReference Include="CMakeLists.txt" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="OsSpecific" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/Interop/COM/NativeClients/DefaultInterfaces.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,8 @@
<ProjectReference Include="../NetServer/NetServer.DefaultInterfaces.ilproj" />
<ProjectReference Include="$(SourceDir)Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="OsSpecific" />
</ItemGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), Interop.settings.targets))\Interop.settings.targets" />
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/Interop/COM/NativeClients/Dispatch.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,8 @@
<ProjectReference Include="../NetServer/NetServer.csproj" />
<ProjectReference Include="$(SourceDir)Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="OsSpecific" />
</ItemGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), Interop.settings.targets))\Interop.settings.targets" />
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/Interop/COM/NativeClients/Licensing.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,8 @@
<ProjectReference Include="../NetServer/NetServer.csproj" />
<ProjectReference Include="$(SourceDir)Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="OsSpecific" />
</ItemGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), Interop.settings.targets))\Interop.settings.targets" />
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/Interop/COM/NativeClients/Primitives.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,8 @@
<ProjectReference Include="../NetServer/NetServer.csproj" />
<ProjectReference Include="$(SourceDir)Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="OsSpecific" />
</ItemGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), Interop.settings.targets))\Interop.settings.targets" />
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/Interop/DllImportAttribute/DllImportPath/DllImportPathTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@
<ItemGroup>
<ProjectReference Include="CMakeLists.txt" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="OsSpecific" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/Interop/DllImportAttribute/ExactSpelling/ExactSpellingTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,7 @@
<ItemGroup>
<ProjectReference Include="CMakeLists.txt" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="OsSpecific" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/Interop/ICustomMarshaler/Primitives/ICustomMarshaler.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,7 @@
<Compile Include="ICustomMarshaler.cs" />
<Compile Include="..\..\common\XunitBase.cs" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="OsSpecific" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/Interop/NativeLibraryResolveCallback/CallbackStressTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,7 @@
<ItemGroup>
<ProjectReference Include="CMakeLists.txt" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="OsSpecific" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/JIT/Directed/arglist/vararg.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,7 @@
<ItemGroup>
<ProjectReference Include="CMakeLists.txt" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="OsSpecific" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/JIT/Regression/JitBlue/GitHub_23199/GitHub_23199.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,7 @@ export COMPlus_GcStressOnDirectCalls=1
<ItemGroup>
<Compile Include="$(MSBuildProjectName).cs" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="BitSpecific" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/JIT/SIMD/VectorConvert_r.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,7 @@
<Compile Include="VectorConvert.cs" />
<Compile Include="VectorUtil.cs" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="BitSpecific" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/JIT/SIMD/VectorConvert_ro.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,7 @@
<Compile Include="VectorConvert.cs" />
<Compile Include="VectorUtil.cs" />
</ItemGroup>
<ItemGroup>
<TraitTags Include="BitSpecific" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions src/coreclr/tests/src/baseservices/exceptions/WindowsEventLog/WindowsEventLog.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,7 @@
<ItemGroup>
<Compile Include="$(MSBuildProjectName).cs" />
</ItemGroup>
<ItemGroup>
Copy link
Member

@VSadov VSadov Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be the TagList ? I actually like TraitTags more, just want to confirm this is intentional use of the name.

Copy link
Contributor Author

@ivdiazsa ivdiazsa Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, TraitTags is the name currently given to the taglist.

Copy link
Member

@trylek trylek Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit I give a damn about the actual identifier. As you two guys are mostly working on this now and no work has been done to support these in the actual test projects AFAIK, I guess you two just figure out whatever naming you're happy with.

Copy link
Member

@VSadov VSadov Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too :-) . Just wanted to make sure this is not something different.
TraitTags sounds good to me.

<TraitTags Include="OsSpecific" />
</ItemGroup>
</Project>