Skip to content

[Group 2] Enable nullable annotations for Microsoft.Extensions.Caching.Abstractions#64018

Merged
eerhardt merged 2 commits intodotnet:mainfrom
maxkoshevoi:mk/43605-caching-abstraction
Feb 7, 2022
Merged

[Group 2] Enable nullable annotations for Microsoft.Extensions.Caching.Abstractions#64018
eerhardt merged 2 commits intodotnet:mainfrom
maxkoshevoi:mk/43605-caching-abstraction

Conversation

@maxkoshevoi
Copy link
Contributor

@maxkoshevoi maxkoshevoi commented Jan 19, 2022

Related to #43605
Fixes: #52148

@ghost
Copy link

ghost commented Jan 19, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 19, 2022
@ghost
Copy link

ghost commented Jan 19, 2022

Tagging subscribers to this area: @dotnet/area-extensions-caching
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #43605
Fixes: #52148

Author: maxkoshevoi
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-Caching
Milestone: -

@eerhardt eerhardt self-assigned this Jan 20, 2022
eerhardt
eerhardt reviewed Jan 21, 2022
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. I just have one comment.

BTW - have you locally tried building/annotating MS.Ext.Caching.Memory to ensure these annotations are correct?

@maxkoshevoi
Copy link
Contributor Author

maxkoshevoi commented Jan 21, 2022

have you locally tried building/annotating MS.Ext.Caching.Memory to ensure these annotations are correct?

Yep, I've also annotated Caching.Memory. Didn't create a PR for it, since PR for Extensions.Options is not merged yet, so some annotations might be wrong.

@maxkoshevoi maxkoshevoi mentioned this pull request Jan 22, 2022
Closed
eerhardt
eerhardt approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, @maxkoshevoi! LGTM.

Sorry for the delay in reviewing.

@eerhardt eerhardt merged commit c003339 into dotnet:main Feb 7, 2022
@maxkoshevoi maxkoshevoi deleted the mk/43605-caching-abstraction branch February 7, 2022 23:47
@maryamariyan maryamariyan mentioned this pull request Feb 8, 2022
Closed
@maxkoshevoi maxkoshevoi mentioned this pull request Feb 23, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees

@eerhardt eerhardt

Labels

area-Extensions-Caching community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update IDistributedCache to account for nullability

3 participants

@maxkoshevoi @eerhardt @maryamariyan