Skip to content

ILVerify: Handle readonly references in ldfld #64077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 3 commits into from
Jan 21, 2022
Merged

ILVerify: Handle readonly references in ldfld #64077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e28b1de
ILVerify: Handle readonly references in ldfld
jkotas Jan 21, 2022
639b4dc
Fix test name
jkotas Jan 21, 2022
9a408e0
Update src/tests/ilverify/ILTests/ValueTypeTests.il
jkotas Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/tools/ILVerification/ILImporter.Verify.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2060,7 +2060,7 @@ void ImportLoadField(int token, bool isStatic)
actualThis = StackValue.CreateByRef(actualThis.Type);

var declaredThis = owningType.IsValueType ?
StackValue.CreateByRef(owningType) : StackValue.CreateObjRef(owningType);
StackValue.CreateByRef(owningType, readOnly : true) : StackValue.CreateObjRef(owningType);

CheckIsAssignable(actualThis, declaredThis);

Expand Down
13 changes: 13 additions & 0 deletions src/tests/ilverify/ILTests/ValueTypeTests.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,16 @@
}
}

.class public sequential ansi sealed beforefieldinit ValueTypeFieldTests
extends [System.Runtime]System.ValueType
{
.field public int32 InstanceField

.method public static int32 ValueType.UnboxLdfld_Valid(object o) cil managed
{
ldarg.0
unbox ValueTypeFieldTests
ldfld int32 ValueTypeFieldTests::InstanceField
ret
}
}