Permit longer chain building fetching for dynamic revocation tests #64496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-System.Security
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsThis is meant to address the flakiness where chain building can time out for very busy CI machines. As we have seen several times, revocation / AIA fetching can take some time. The test fixture is already outerloop, so extending the timeout should not adversely affect CI inner loop performance. Closes #734.
|
bartonjs
approved these changes
Jan 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address the flakiness where chain building can time out for very busy CI machines. As we have seen several times, revocation / AIA fetching can take some time.
The test fixture is already outerloop, so extending the timeout should not adversely affect CI inner loop performance.
Closes #734.