Skip to content

Do not add NRE sets for non-null addresses #64607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobbotsch merged 1 commit into from
Feb 1, 2022
Merged

Do not add NRE sets for non-null addresses #64607

jakobbotsch merged 1 commit into from
Feb 1, 2022

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Feb 1, 2022

Ref: #63845 (comment) and the subsequent discussion.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed community-contribution Indicates that the PR has been added by a community member labels Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Ref: #63845 (comment) and the subsequent discussion.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review February 1, 2022 09:54
@jakobbotsch
Copy link
Member

jakobbotsch commented Feb 1, 2022

Failure is #60154

@jakobbotsch jakobbotsch merged commit 06a709d into dotnet:main Feb 1, 2022
@SingleAccretion SingleAccretion deleted the No-Null-No-Exc-Sets branch February 1, 2022 15:16
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Mar 3, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SingleAccretion @jakobbotsch