Skip to content

Conversation

@trylek
Copy link
Member

@trylek trylek commented Feb 5, 2022

For the project renames, the only goal was to establish the invariant that
"_il_d" and "_il_r" denote IL tests. For the System.Runtime reference, I don't have
any great idea what exactly's going on - without the changes merged build fails with

"System.Object is defined in an assembly that is not referenced, you must add a reference to System.Runtime"

In all cases except for "delegatetail.il" these tests are "special" in the sense that they qualify the System.Object
type with the [System.Runtime] instead of [mscorlib] assembly as the remaining tests do. I have no idea what
the compiler doesn't like about the delegatetail.il test.

All these recent changes I'm publishing contribute to the test consolidation task
(there are just about 2-3 more to go). Please let me know if you think that fixing the PKT
is not the right way to fix this, feel free to suggest a different solution.

Thanks

Tomas

/cc @dotnet/jit-contrib

@ghost
Copy link

ghost commented Feb 5, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

For the project renames, the only goal was to establish the invariant that
"_il_d" and "_il_r" denote IL tests. For the System.Runtime reference, I don't have
any great idea what exactly's going on - without the changes merged build fails with

"System.Object is defined in an assembly that is not referenced, you must add a reference to System.Runtime"

In all cases except for "delegatetail.il" these tests are "special" in the sense that they qualify the System.Object
type with the [System.Runtime] instead of [mscorlib] assembly as the remaining tests do. I have no idea what
the compiler doesn't like about the delegatetail.il test.

All these recent changes I'm publishing contribute to the test consolidation task
(there are just about 2-3 more to go). Please let me know if you think that fixing the PKT
is not the right way to fix this, feel free to suggest a different solution.

Thanks

Tomas

/cc @dotnet/jit-contrib

Author: trylek
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: 7.0.0

@ghost ghost assigned trylek Feb 5, 2022
@trylek
Copy link
Member Author

trylek commented Feb 7, 2022

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try replacing all references to 'System.Runtime' with 'mscorlib' in IL tests? (Would that even be expected to work in all cases?)

@trylek
Copy link
Member Author

trylek commented Feb 8, 2022

@BruceForstall - I did not, perhaps it might also resolve the issue but I tried to avoid excessively churning the codebase by making bulky refactorings - there are about 2.5K occurrences of [System.Runtime]System.Object in the test tree today. I agree there's value in further cleanup but for now I believe it's most important to land the primary consolidation.

@trylek trylek merged commit 205f70e into dotnet:main Feb 8, 2022
@trylek trylek deleted the JIT-Methodical-reference-versions branch February 8, 2022 23:58
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants