Skip to content

For LclHeap touch a page at [originalSp] not at [originalSp+amount] #65088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
echesakov merged 1 commit into from
Feb 9, 2022
Merged

For LclHeap touch a page at [originalSp] not at [originalSp+amount] #65088

echesakov merged 1 commit into from
Feb 9, 2022

Conversation

@echesakov
Copy link
Contributor

@echesakov echesakov commented Feb 9, 2022

Fixes #65058

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 9, 2022
@ghost ghost assigned echesakov Feb 9, 2022
@ghost
Copy link

ghost commented Feb 9, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #65058

Author: echesakovMSFT
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@echesakov
Copy link
Contributor Author

echesakov commented Feb 9, 2022 •
edited
Loading

@MichalStrehovsky Do you still have a setup for reproducing the issue? Can you please help me to validate the fix?

@MichalStrehovsky
Copy link
Member

MichalStrehovsky commented Feb 9, 2022

The CI non-deterministically hits this in the NativeAOT legs (I assume hitting it depends on ASLR or something like that). I verified the disassembly of the problematic method and the problematic ldr wzr, [sp, #0x400] turned into ldr wzr, [sp] so it looks good! Thank you!

@echesakov
Copy link
Contributor Author

echesakov commented Feb 9, 2022

The CI non-deterministically hits this in the NativeAOT legs (I assume hitting it depends on ASLR or something like that). I verified the disassembly of the problematic method and the problematic ldr wzr, [sp, #0x400] turned into ldr wzr, [sp] so it looks good! Thank you!

Thank you for verifying!

@echesakov echesakov merged commit bdae9b9 into dotnet:main Feb 9, 2022
@echesakov echesakov deleted the Runtime_65058 branch February 9, 2022 23:19
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@echesakov echesakov

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Possible issue with guard pages on Windows ARM64

3 participants

@echesakov @MichalStrehovsky @BruceForstall