Do not run jit-cfg on macOS #65125
Closed
Do not run jit-cfg on macOS #65125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jit-cfg includes a GCStress scenario which is not supported on macOS x64. Rather than excluding it just there, just exclude all of macOS since CFG is a Windows only feature anyway. I am still keeping the Linux-x64/Linux-arm64 jobs as we produce different IR for arguments on these ABIs and I want to keep the CFG handling working in general for all the forms of IR we can produce related to calls.
ghost
added
the
|
Tagging subscribers to this area: @hoyosjs Issue Detailsjit-cfg includes a GCStress scenario which is not supported on macOS I am still keeping the Linux-x64/Linux-arm64 jobs as we produce
|
Member
Author
|
Superseded by #65127. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jit-cfg includes a GCStress scenario which is not supported on macOS
x64. Rather than excluding it just there, just exclude all of macOS
since CFG is a Windows only feature anyway.
I am still keeping the Linux-x64/Linux-arm64 jobs as we produce
different IR for arguments on these ABIs and I want to keep the CFG
handling working in general for all the forms of IR we can produce
related to calls.