Skip to content

Conversation

@stephentoub
Copy link
Member

Primarily to ingest the updates that support C# 10 language features, e.g. that structs can now have parameterless ctors.

@ghost ghost assigned stephentoub Feb 10, 2022
@ghost ghost added the area-Meta label Feb 10, 2022
@ghost
Copy link

ghost commented Feb 10, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Primarily to ingest the updates that support C# 10 language features, e.g. that structs can now have parameterless ctors.

Author: stephentoub
Assignees: stephentoub
Labels:

area-Meta

Milestone: -

@stephentoub stephentoub force-pushed the updatestylecop branch 2 times, most recently from da21de2 to 0fc7fa3 Compare February 10, 2022 21:12
@danmoseley
Copy link
Member

Add missing newlines at end of files to satisfy changes to SA1518

Maybe we should disable this rule for this repo? As far as I know it's a convention on Unix only because it's convenient for some operations like appending files, counting lines etc. Seems like a low value thing to break a build.

@stephentoub
Copy link
Member Author

Maybe we should disable this rule for this repo? As far as I know it's a convention on Unix only because it's convenient for some operations like appending files, counting lines etc. Seems like a low value thing to break a build.

I don't have a strong opinion, but the overwhelming majority of our files already do this, and VS adds them automatically, so I don't think it's a big deal to get clean and then stay clean.

@stephentoub stephentoub force-pushed the updatestylecop branch 2 times, most recently from 5070a46 to 03b6323 Compare February 11, 2022 01:40
@stephentoub stephentoub merged commit 65008a9 into dotnet:main Feb 11, 2022
@stephentoub stephentoub deleted the updatestylecop branch February 11, 2022 15:03
@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants