Skip to content

Conversation

@maxkoshevoi
Copy link
Contributor

Related to #43605

@eerhardt is it Ok if I finish up the #43605 story, or am I gonna mess up your sprint planning by creating these PRs?

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-Extensions-Options new-api-needs-documentation and removed community-contribution Indicates that the PR has been added by a community member labels Feb 11, 2022
@ghost
Copy link

ghost commented Feb 11, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Feb 11, 2022

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #43605

@eerhardt is it Ok if I finish up the #43605 story, or am I gonna mess up your sprint planning by creating these PRs?

Author: maxkoshevoi
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-Options

Milestone: -

@eerhardt
Copy link
Member

is it Ok if I finish up the #43605 story, or am I gonna mess up your sprint planning by creating these PRs?

It is 100% OK. Keep them coming.

@eerhardt eerhardt merged commit 3c5fee9 into dotnet:main Feb 11, 2022
@maxkoshevoi maxkoshevoi deleted the mk/43605-options-dataannotations branch February 11, 2022 23:19
@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants