Skip to content

Store the result in the return local in native-to-managed IL stubs. #65203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkoritzinsky merged 2 commits into from
Feb 12, 2022
Merged

Store the result in the return local in native-to-managed IL stubs. #65203

jkoritzinsky merged 2 commits into from
Feb 12, 2022

Conversation

@jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Feb 11, 2022

Fixes #65177

Sorted includes is from the auto-formatter.

@ghost ghost assigned jkoritzinsky Feb 11, 2022
@ghost
Copy link

ghost commented Feb 11, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #65177

Sorted includes is from the auto-formatter.

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices, runtime-mono
Milestone: -

@AaronRobinsonMSFT
Copy link
Member

AaronRobinsonMSFT commented Feb 11, 2022

Sorted includes is from the auto-formatter.

I would turn this off then. Reordering includes is fraught and can destabilize things.

@jkoritzinsky
Copy link
Member Author

jkoritzinsky commented Feb 11, 2022 •
edited
Loading

Mono should change their formatter configuration if they don't want the includes sorted. Otherwise there's no way to enforce formatting.

lambdageek
lambdageek approved these changes Feb 11, 2022
View reviewed changes
src/mono/mono/metadata/marshal-ilgen.c
#include <errno.h>
#include <mono/utils/mono-error-internals.h>
#include <mono/utils/mono-threads-coop.h>
#include <mono/utils/mono-threads.h>
Copy link
Member

@lambdageek lambdageek Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: slightly prefer if we could drop unrelated reformatting.

@lambdageek
Copy link
Member

lambdageek commented Feb 11, 2022

Mono should change their formatter configuration if they don't want the includes sorted. Otherwise there's no way to enforce formatting.

How do I do that? I'm an .editorconfig noob

@jkoritzinsky
Copy link
Member Author

jkoritzinsky commented Feb 11, 2022

Removed the formatting changes for now.

I think that we'd need to switch Mono to using .clang-format instead of .editorconfig to get the options needed.

@jkoritzinsky
Copy link
Member Author

jkoritzinsky commented Feb 11, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 11, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky jkoritzinsky merged commit e04d750 into dotnet:main Feb 12, 2022
@jkoritzinsky jkoritzinsky deleted the mono-il-fix branch February 12, 2022 06:42
@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageek lambdageek lambdageek approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@elinor-fung elinor-fung elinor-fung approved these changes

@vargaz vargaz Awaiting requested review from vargaz

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

Assignees

@jkoritzinsky jkoritzinsky

Labels

area-System.Runtime.InteropServices runtime-mono specific to the Mono runtime

Projects

None yet

Milestone

No milestone

4 participants

@jkoritzinsky @AaronRobinsonMSFT @lambdageek @elinor-fung