Skip to content

Conversation

@lewing
Copy link
Member

@lewing lewing commented Feb 18, 2022

Upgrade the bundled npm instead of removing it so that the typescript tooling can function from the emsdk npm

@ghost ghost assigned lewing Feb 18, 2022
@ghost ghost added the area-Build-mono label Feb 18, 2022
@lewing lewing requested a review from radical February 18, 2022 16:53
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some extra newlines

@lewing lewing requested a review from steveisok February 18, 2022 20:55
@lewing lewing marked this pull request as ready for review February 18, 2022 20:56
@lewing lewing requested a review from marek-safar as a code owner February 18, 2022 20:56
@lewing lewing requested a review from maraf February 18, 2022 21:33
@lewing lewing merged commit 06228c1 into dotnet:main Feb 18, 2022
@lewing lewing deleted the wasm-sanitize-upgrade branch February 19, 2022 01:23
@lewing
Copy link
Member Author

lewing commented Feb 19, 2022

@DrewScoggins this should unbreak the wasm build on the perf pipeline

@lewing
Copy link
Member Author

lewing commented Feb 19, 2022

looks like dotnet/performance#2250 and dotnet/BenchmarkDotNet#1926 will need to make it through the pipeline as well

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants