Skip to content

Fix NTAuthentication.MakeSignature/VerifySignature on Linux #65679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wfurt merged 3 commits into from
May 12, 2022
Merged

Fix NTAuthentication.MakeSignature/VerifySignature on Linux #65679

wfurt merged 3 commits into from
May 12, 2022

Conversation

@filipnavara
Copy link
Member

@filipnavara filipnavara commented Feb 21, 2022 •
edited
Loading

Contributes to #65678

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Net.Security labels Feb 21, 2022
@ghost
Copy link

ghost commented Feb 21, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Build on top of #65611, contributes to #65678

Author: filipnavara
Assignees: -
Labels:

area-System.Net.Security, community-contribution
Milestone: -

@filipnavara filipnavara changed the title Fix NTAuthentication.MakeSignature on Linux Fix NTAuthentication.MakeSignature/VerifySignature on Linux and macOS Feb 22, 2022
@filipnavara

This comment was marked as outdated.

Sign in to view
@filipnavara filipnavara changed the title Fix NTAuthentication.MakeSignature/VerifySignature on Linux and macOS Fix NTAuthentication.MakeSignature/VerifySignature on Linux Feb 22, 2022
@ghost ghost closed this Mar 25, 2022
@ghost
Copy link

ghost commented Mar 25, 2022

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.

@filipnavara filipnavara reopened this Mar 25, 2022
@ghost ghost added the no-recent-activity label Apr 15, 2022
@ghost
Copy link

ghost commented Apr 15, 2022

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost
Copy link

ghost commented Apr 30, 2022

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@ghost ghost closed this Apr 30, 2022
@filipnavara filipnavara reopened this May 7, 2022
@ghost ghost removed the no-recent-activity label May 7, 2022
@filipnavara filipnavara requested a review from wfurt May 7, 2022 07:03
@filipnavara filipnavara marked this pull request as ready for review May 7, 2022 07:19
wfurt
wfurt approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt
Copy link
Member

wfurt commented May 12, 2022

System.IO.Pipes.Tests failure is unrelated.

@wfurt wfurt merged commit 7b5f40f into dotnet:main May 12, 2022
@rzikm rzikm mentioned this pull request May 13, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
@filipnavara filipnavara deleted the ntlm_test_2 branch June 5, 2025 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurt wfurt wfurt approved these changes

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Net.Security community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@filipnavara @wfurt @am11 @karelz