Fix case of passing regNumber as regMaskTP #65907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No asm diffs, so I'm suspicious whether this code is ever actually hit.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsNo asm diffs, so I'm suspicious whether this code is ever actually hit.
|
Contributor
Author
|
Trivial change. @kunalspathak @dotnet/jit-contrib PTAL |
kunalspathak
suggested changes
Feb 26, 2022
Contributor
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
Is this fixing anything or this is just something that you noticed and want to correct it?
| { | ||
| // We have loaded this into a register only temporarily | ||
| gcInfo.gcMarkRegSetNpt(reg); | ||
| gcInfo.gcMarkRegSetNpt(genRegMask(reg)); |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
I just noticed it.
Your link didn't work; can you check?
Contributor
Author
There was a problem hiding this comment.
ah, found it. I'll fix both, but I'm going to subsume it into #65916
ghost
added
needs-author-action
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No asm diffs, so I'm suspicious whether this code is ever actually hit.