Skip to content

Conversation

@vseanreesermsft
Copy link

No description provided.

@ghost
Copy link

ghost commented Mar 1, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: vseanreesermsft
Assignees: vseanreesermsft
Labels:

area-Infrastructure-libraries

Milestone: -

…j files (excludes *.Transport.csproj files).
@carlossanlop
Copy link
Contributor

carlossanlop commented Mar 2, 2022

@bartonjs @ericstj need a second set of eyes on this change, just to make sure I'm not messing it up. According to the branding instructions, I need to remove the <GeneratePackageOnBuild>true</GeneratePackageOnBuild> lines I find in all the *.csproj files inside src/libraries/, making sure I exclude *.Transport.csproj files (those are never modified).

For this branding, I found 5 files. Does the change look good? Do any of the files look like it should not be modified?

@tannergooding there is an Internal.csproj file from your area. Do we need to release this package every time?

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, compared to reference commit 116a09f

We no longer need to remove the ref pack.

<DefineConstants>$(DefineConstants);FEATURE_NFLOAT</DefineConstants>
<IsPackable>true</IsPackable>
<ServicingVersion>1</ServicingVersion>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd defer to @ericstj here.

This is a "new" package, not one that shipped in .NET 6 RTM and is the "special" package meant to support Xamarin/MAUI.

I'm uncertain if there is any special consideration due to that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Xamarin/MAUI expect us to give them a new build every time we service, or only if there are changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe only if there are changes. But we should confirm with @rolfbjarne

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a new version unless something changes, and in any case I hardcoded the version we reference as 6.0.1, so it would also make our lives easier if the version didn't bump unnecessarily :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you everyone. So the change as it is right now seems to be the correct one.

@carlossanlop carlossanlop merged commit 13a0b28 into dotnet:release/6.0 Mar 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants