-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Update branding to 6.0.4 #66021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update branding to 6.0.4 #66021
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailsnull
|
…j files (excludes *.Transport.csproj files).
|
@bartonjs @ericstj need a second set of eyes on this change, just to make sure I'm not messing it up. According to the branding instructions, I need to remove the For this branding, I found 5 files. Does the change look good? Do any of the files look like it should not be modified? @tannergooding there is an |
ericstj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me, compared to reference commit 116a09f
We no longer need to remove the ref pack.
| <DefineConstants>$(DefineConstants);FEATURE_NFLOAT</DefineConstants> | ||
| <IsPackable>true</IsPackable> | ||
| <ServicingVersion>1</ServicingVersion> | ||
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd defer to @ericstj here.
This is a "new" package, not one that shipped in .NET 6 RTM and is the "special" package meant to support Xamarin/MAUI.
I'm uncertain if there is any special consideration due to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Xamarin/MAUI expect us to give them a new build every time we service, or only if there are changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe only if there are changes. But we should confirm with @rolfbjarne
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a new version unless something changes, and in any case I hardcoded the version we reference as 6.0.1, so it would also make our lives easier if the version didn't bump unnecessarily :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you everyone. So the change as it is right now seems to be the correct one.
No description provided.