Skip to content

[tests] Update eventsvalidation tests to use intree Microsoft.Diagnostics.NETCore.Client #66110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hoyosjs merged 2 commits into from
Mar 3, 2022
Merged

[tests] Update eventsvalidation tests to use intree Microsoft.Diagnostics.NETCore.Client #66110

hoyosjs merged 2 commits into from
Mar 3, 2022

Conversation

@mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Mar 2, 2022

Fixes #66099

@mdh1418 mdh1418 requested review from BruceForstall and hoyosjs March 2, 2022 21:21
@ghost ghost added the area-Tracing-coreclr label Mar 2, 2022
@ghost ghost assigned mdh1418 Mar 2, 2022
@mdh1418
Copy link
Member Author

mdh1418 commented Mar 2, 2022

@BruceForstall How can I run the runtime-coreclr jitstress pipeline?

@hoyosjs
Copy link
Member

hoyosjs commented Mar 2, 2022

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 2, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall
Copy link
Contributor

BruceForstall commented Mar 2, 2022

Just triggering runtime-coreclr outerloop would have been sufficient.

Once the CoreCLR Common Pri1 Test Build AnyOS AnyCPU checked job in the jitstress pipeline (https://dev.azure.com/dnceng/public/_build/results?buildId=1641394&view=results) succeeds, you can consider this "good" -- no need to wait for all test runs to complete.

@BruceForstall
Copy link
Contributor

BruceForstall commented Mar 2, 2022

@mdh1418 @hoyosjs The build failure is not fixed:

    gh53564 -> /__w/1/s/artifacts/tests/coreclr/AnyOS.x64.Checked/tracing/eventcounter/gh53564/gh53564.dll
/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/ExceptionThrown_V1.cs(20,74): error CS1503: Argument 2: cannot convert from 'int' to 'System.Diagnostics.Tracing.EventLevel' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/ExceptionThrown_V1.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/tests/tracing/eventpipe/eventsvalidation/ExceptionThrown_V1.cs(20,74): error CS1503: Argument 2: cannot convert from 'int' to 'System.Diagnostics.Tracing.EventLevel' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/ExceptionThrown_V1.csproj]
/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/ExceptionThrown_V1.cs(20,97): error CS1503: Argument 3: cannot convert from 'System.Diagnostics.Tracing.EventLevel' to 'long' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/ExceptionThrown_V1.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/tests/tracing/eventpipe/eventsvalidation/ExceptionThrown_V1.cs(20,97): error CS1503: Argument 3: cannot convert from 'System.Diagnostics.Tracing.EventLevel' to 'long' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/ExceptionThrown_V1.csproj]
    regression-25709 -> /__w/1/s/artifacts/tests/coreclr/AnyOS.x64.Checked/tracing/eventcounter/regression-25709/regression-25709.dll
    EventListenerThreadPool -> /__w/1/s/artifacts/tests/coreclr/AnyOS.x64.Checked/tracing/eventlistener/EventListenerThreadPool/EventListenerThreadPool.dll
/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCEvents.cs(19,21): error CS7036: There is no argument given that corresponds to the required formal parameter 'eventLevel' of 'EventPipeProvider.EventPipeProvider(string, EventLevel, long, IDictionary<string, string>)' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCEvents.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/tests/tracing/eventpipe/eventsvalidation/GCEvents.cs(19,21): error CS7036: There is no argument given that corresponds to the required formal parameter 'eventLevel' of 'EventPipeProvider.EventPipeProvider(string, EventLevel, long, IDictionary<string, string>)' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCEvents.csproj]
/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCEvents.cs(21,74): error CS1503: Argument 2: cannot convert from 'int' to 'System.Diagnostics.Tracing.EventLevel' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCEvents.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/tests/tracing/eventpipe/eventsvalidation/GCEvents.cs(21,74): error CS1503: Argument 2: cannot convert from 'int' to 'System.Diagnostics.Tracing.EventLevel' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCEvents.csproj]
/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCEvents.cs(21,79): error CS1503: Argument 3: cannot convert from 'System.Diagnostics.Tracing.EventLevel' to 'long' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCEvents.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/tests/tracing/eventpipe/eventsvalidation/GCEvents.cs(21,79): error CS1503: Argument 3: cannot convert from 'System.Diagnostics.Tracing.EventLevel' to 'long' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCEvents.csproj]
    eventlistener -> /__w/1/s/artifacts/tests/coreclr/AnyOS.x64.Checked/tracing/eventlistener/eventlistener/eventlistener.dll
/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.cs(19,21): error CS7036: There is no argument given that corresponds to the required formal parameter 'eventLevel' of 'EventPipeProvider.EventPipeProvider(string, EventLevel, long, IDictionary<string, string>)' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.cs(19,21): error CS7036: There is no argument given that corresponds to the required formal parameter 'eventLevel' of 'EventPipeProvider.EventPipeProvider(string, EventLevel, long, IDictionary<string, string>)' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.csproj]
/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.cs(21,74): error CS1503: Argument 2: cannot convert from 'int' to 'System.Diagnostics.Tracing.EventLevel' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.cs(21,74): error CS1503: Argument 2: cannot convert from 'int' to 'System.Diagnostics.Tracing.EventLevel' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.csproj]
/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.cs(21,79): error CS1503: Argument 3: cannot convert from 'System.Diagnostics.Tracing.EventLevel' to 'long' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.cs(21,79): error CS1503: Argument 3: cannot convert from 'System.Diagnostics.Tracing.EventLevel' to 'long' [/__w/1/s/src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.csproj]
    regression-46938 -> /__w/1/s/artifacts/tests/coreclr/AnyOS.x64.Checked/tracing/eventcounter/regression-46938/regression-46938.dll

@BruceForstall BruceForstall mentioned this pull request Mar 2, 2022
Merged
@mdh1418
Copy link
Member Author

mdh1418 commented Mar 2, 2022

I went too quickly, I missed that the EventPipeProvider does not have a default EventLevel, and that the keyword position is changed to be 3rd instead of second.

@mdh1418
Copy link
Member Author

mdh1418 commented Mar 3, 2022

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 3, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member Author

mdh1418 commented Mar 3, 2022

@BruceForstall https://dev.azure.com/dnceng/public/_build/results?buildId=1641823&view=logs&j=db768a9e-3325-5ce3-2d52-896c40bee68a is green now. Is this still good to merge despite the other seemingly unrelated failures?

@hoyosjs hoyosjs merged commit 73471b5 into dotnet:main Mar 3, 2022
@hoyosjs
Copy link
Member

hoyosjs commented Mar 3, 2022

Merged to unblock JIT workflows. The errors were due to AzDO artifact throttling unrelated to this PR.

@mdh1418 mdh1418 deleted the fix_eventpipeprovider_not_referenced branch March 3, 2022 01:24
@BruceForstall
Copy link
Contributor

BruceForstall commented Mar 3, 2022

As long as the test build finished (it did), that's good enough for now.

Of course, if these changes also cause test failures, you'll see those soon...

@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

@BruceForstall BruceForstall Awaiting requested review from BruceForstall

Assignees

@mdh1418 mdh1418

Labels

area-Tracing-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test build failure: The type 'EventPipeProvider' is defined in an assembly that is not referenced

3 participants

@mdh1418 @hoyosjs @BruceForstall