Fix System.IO.Ports native package not getting published any longer after the oob + sfx split#66176
Conversation
…fter the oob + sfx split
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsFYI: @ViktorHofer @ericstj @mmitche The native component package of System.IO.Ports doesn't get build in the all configurations leg, and instead should be build in individual Unix verticals. With the recent changes to split sfx and oob builds, these packages builds got moved into the all configurations leg in Windows which would never build the unix packages. The changes in this PR will fix this and have the native packages build on the individual verticals as they were before.
|
|
Thanks @carlossanlop for the help investigating. |
|
@dreddy-work what do we need to do to unblock you after this gets merged to main? |
|
We don’t need to do anything to unblock them, dependency flow will update that PR with the versions that have the fix |
|
Adding the No-Merge label until I validate on the CI builds that the changes actually produce the packages as expected. Once I validate this I’ll remove the label and merge. |
|
Thank you, I missed that during my refactoring. It's a shame that we don't have PR validation to make sure the expected set of packages are generated. Ie a restore of the System.IO.Ports would have raised this issue. Unsure if it's possible but maybe we could have package feeds just for PR validation? cc @mmitche |
|
That is exactly what we do when we run our package validation tests, the only package we don’t run this validation on is System.IO.Ports, and the reason is that we don’t have one build that we can run that test on which has all the required packages for restore to work: since this is special cased there already, perhaps we can also special case a test on individual verticals that are expected to produce these which would validate that they actually got generated. |
|
Right. What I was trying to say is that it might be possible to make this work and remove the validation exclusion by sequencing when testPackages runs differently. There are obvious downsides to that but it should at least be discussed :) |
FYI: @ViktorHofer @ericstj @mmitche
The native component package of System.IO.Ports doesn't get build in the all configurations leg, and instead should be build in individual Unix verticals. With the recent changes to split sfx and oob builds, these packages builds got moved into the all configurations leg in Windows which would never build the unix packages. The changes in this PR will fix this and have the native packages build on the individual verticals as they were before.