Run illink before ApiCompat

[ViktorHofer]

As observed in #66634 (comment), illink currently runs after APICompat. This happens because nuget imports the ApiCompat targets earlier than the illink.targets is imported.

This should flag issues where illink removes interfaces even though it shouldn't in library mode.

cc @bartonjs @ericstj

[ghost]

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

---

As observed in #66634 (comment), illink currently runs after APICompat. This happens because nuget imports the ApiCompat targets earlier than the illink.targets is imported.

This should flag issues where illink removes interfaces even though it shouldn't in library mode.

cc @bartonjs @ericstj

Author:	ViktorHofer
Assignees:	-
Labels:	linkable-framework
Milestone:	-

[bartonjs]

I think, in my head, the ideal model is that GenAPI would run from the untrimmed compiler output, and APICompat would run on the trimmer output. That way if GenAPI thinks something is relevant that the trimmer didn't, we catch it.

[vitek-karas]

The trimmer problem dotnet/linker#2238 has been fixed. Once it flows into runtime it should not remove any of the interfaces (or their methods).

[ViktorHofer]

The change is now ready. PTAL

[ViktorHofer]

@ericstj @carlossanlop @dotnet/area-infrastructure-libraries can someone please approve?

[eerhardt]

LGTM