[mono] Move basic w32file* and w32process* functions to eventpipe #66731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
requested review from
BrzVlad,
SamMonoRT,
lambdageek,
lateralusX,
marek-safar,
naricc,
thaystg and
vargaz
as code owners
They are not used by the rest of the runtime and we only need a bare minimum of w32process and w32file in eventpipe (e.g. no file share/access logic). Fix ep-test build and warnings, it was missing linking against libz and monoapi. Fix host vs. target confusion in ep-rt-mono.c
akoeplinger
force-pushed
the
w32-cleanup
branch
from
f0eac94 to
e82c20a
Compare
lambdageek
reviewed
Mar 17, 2022
|
|
||
| /* clock_gettime () is found by configure on Apple builds, but its only present from ios 10, macos 10.12, tvos 10 and watchos 3 */ | ||
| #if defined (HAVE_CLOCK_MONOTONIC) && (defined(TARGET_IOS) || defined(TARGET_OSX) || defined(TARGET_WATCHOS) || defined(TARGET_TVOS)) | ||
| #if defined (HAVE_CLOCK_MONOTONIC) && (defined(HOST_IOS) || defined(HOST_OSX) || defined(HOST_WATCHOS) || defined(HOST_TVOS)) |
Member
There was a problem hiding this comment.
isn't HOST_DARWIN supposed to encompass all of these?
Member
There was a problem hiding this comment.
Also: ios 10, macos 10.12, etc are pretty old. Do we still need this?
Member
There was a problem hiding this comment.
Minimum supported macOS version is 10.15 in .NET 6, per https://github.com/dotnet/core/blob/main/release-notes/6.0/supported-os.md#macos.
Member
Author
There was a problem hiding this comment.
lateralusX
reviewed
Mar 17, 2022
Member
lateralusX
left a comment
lateralusX
left a comment
There was a problem hiding this comment.
Overall I think it looks great, nice work!. Most comments are formatting and some around adapting ported code to EventPipe types where possible.
Co-authored-by: Johan Lorensson <lateralusx.github@gmail.com>
Fix more formatting. Move initialization of num_main_args after setting main_args so we can use it as a cheap guard value (not totally thread-safe but good enough for our purposes)
Move cmdline formatting back into object.c Fix bug return INVALID_HANDLE_VALUE instead of null in ep_rt_file_open_write
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
…tnet#66731) They are not used by the rest of the runtime and we only need a bare minimum of w32process and w32file in eventpipe (e.g. no file share/access logic). Fix ep-test build and warnings, it was missing linking against libz and monoapi. Fix host vs. target confusion in ep-rt-mono.c Move initialization of num_main_args after setting main_args in object.c so we can use it as a cheap guard value (not totally thread-safe but good enough for our purposes). Co-authored-by: Johan Lorensson <lateralusx.github@gmail.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not used by the rest of the runtime and we only need a bare minimum of w32process and w32file in eventpipe (e.g. no file share/access logic).
Fix ep-test build and warnings, it was missing linking against libz and monoapi.
Fix host vs. target confusion in ep-rt-mono.c