Skip to content

Use no-recent-activity in inactive Draft PRs#66771

Merged
eiriktsarpalis merged 1 commit intodotnet:mainfrom
eiriktsarpalis:draft-pr-no-recent-activity
Apr 15, 2022
Merged

Use no-recent-activity in inactive Draft PRs#66771
eiriktsarpalis merged 1 commit intodotnet:mainfrom
eiriktsarpalis:draft-pr-no-recent-activity

Conversation

@eiriktsarpalis
Copy link
Copy Markdown
Member

Following feedback from #65101 (comment) this updates Draft PR auto closing automation to use the no-recent-activity label workflow. Stale PRs will be issued a warning before being closed automatically 14 days later.

@marek-safar
Copy link
Copy Markdown
Contributor

Not a fan of this change with a label after 14 days. If you think this can change things we should just post a comment with a warning a few days before closing Draft PR.

@danmoseley
Copy link
Copy Markdown
Member

I have no opinion on the timeline, just that it seems worth posting a note a little beforehand.

@eiriktsarpalis
Copy link
Copy Markdown
Member Author

Note that the 14/14 day timing is consistent with what we already have in inactive issues and pull requests. No strong opinion on what should be used instead but it should probably be consistent across the board.

@marek-safar
Copy link
Copy Markdown
Contributor

Not sure what is the goal with consistency here if we are doing a very different action here. Either way, I still think that 14 days is too long and the label has no value on Draft PRs and will make real no-recent-activity filtering harder.

@eiriktsarpalis
Copy link
Copy Markdown
Member Author

eiriktsarpalis commented Mar 22, 2022

I still think that 14 days is too long

FWIW the existing rule closes issues after 30 days of no activity, so other than providing an early warning not much is being changed here.

@ghost
Copy link
Copy Markdown

ghost commented Mar 22, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Following feedback from #65101 (comment) this updates Draft PR auto closing automation to use the no-recent-activity label workflow. Stale PRs will be issued a warning before being closed automatically 14 days later.

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-Meta

Milestone: -

@eiriktsarpalis
Copy link
Copy Markdown
Member Author

What should we do with this PR? Close it?

@danmoseley
Copy link
Copy Markdown
Member

Giving a heads up seems like a positive move. We can consider changing to close them faster in future.

@eiriktsarpalis eiriktsarpalis merged commit 133318c into dotnet:main Apr 15, 2022
@eiriktsarpalis eiriktsarpalis deleted the draft-pr-no-recent-activity branch April 15, 2022 18:29
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants