Skip to content

[wasm] Do not set _WasmDevel=true for blazor projects #66793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsitnik merged 3 commits into from
Mar 22, 2022
Merged

[wasm] Do not set _WasmDevel=true for blazor projects #66793

adamsitnik merged 3 commits into from
Mar 22, 2022

Conversation

@radical
Copy link
Member

@radical radical commented Mar 17, 2022 •
edited
Loading

to workaround wasm-ld getting oomkilled.

Fixes #66725

@radical
[wasm] Do not set _WasmDevel=true for blazor projects
c5e19e7 
to workaround wasm-ld getting oomkilled.

Fixes dotnet#66725, and dotnet#66591
@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Mar 17, 2022
@ghost ghost assigned radical Mar 17, 2022
@ghost
Copy link

ghost commented Mar 17, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

to workaround wasm-ld getting oomkilled.

Fixes #66725, and #66591

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono
Milestone: -

@radical radical requested review from lewing and radekdoulik March 17, 2022 21:14
@radical radical requested a review from akoeplinger March 21, 2022 19:20
@adamsitnik
Copy link
Member

adamsitnik commented Mar 22, 2022

Since this PR has 3 approvals and it fixes #66725 (which blocks clean CI and from Test Monitor perspective is the most common reason for CI failures) I am going to merge it.

@adamsitnik adamsitnik merged commit 22f30fb into dotnet:main Mar 22, 2022
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@radical @radekdoulik
[wasm] Do not set _WasmDevel=true for blazor projects (dotnet#66793)
c73d59d 
* [wasm] Do not set _WasmDevel=true for blazor projects

to workaround wasm-ld getting oomkilled.

Fixes dotnet#66725, and dotnet#66591

* Fix test
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@lambdageek lambdageek lambdageek approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[WASM] BlazorWasmBuildPublishTests getting oomkill'ed during linking

5 participants

@radical @adamsitnik @lewing @lambdageek @akoeplinger