[wasm][debugger] Debugger Proxy: add property accessibility info. #67748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis PR adds a property accessibility level information to the buffer of command: This information is needed to properly sort properties by protection level when sending them to debugger as public/private/other object members should be displayed differently and be sent separately. Connected PRs:
|
Member
|
I think it would be better to have this with a PR that uses this new info too, so it is clear why the hack is needed, and that it actually works. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a property accessibility level information to the buffer of command:
CMD_TYPE_GET_PROPERTIES(CmdType.GetProperties).This information is needed to properly sort properties by protection level when sending them to debugger as public/private/other object members should be displayed differently and be sent separately.
Connected PRs where it will be used:
#63339