Skip to content

Conversation

@eiriktsarpalis
Copy link
Member

Improves assertion error messages in the JsonTestHelpers.AssertJsonEqual helper method.

Before:
image

After:
image

Change extracted from #67961.

@ghost
Copy link

ghost commented Apr 13, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Improves assertion error messages in the JsonTestHelpers.AssertJsonEqual helper method.

Before:
image

After:
image

Change extracted from #67961.

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Text.Json

Milestone: -

@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Apr 13, 2022
Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@eiriktsarpalis eiriktsarpalis merged commit 599f0bc into dotnet:main Apr 15, 2022
@eiriktsarpalis eiriktsarpalis deleted the jsontesthelper-improvements branch April 15, 2022 15:46
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants