Fix compiled / source generated lazy loop stack handling #68138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a lazy loop has completed iterations but then ends up failing, and the thing it's looping around has no backtracking constructs, we're incorrectly leaving some state associated with the loop on the backtracking stack.
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsWhen a lazy loop has completed iterations but then ends up failing, and the thing it's looping around has no backtracking constructs, we're incorrectly leaving some state associated with the loop on the backtracking stack.
|
joperezr
reviewed
Apr 18, 2022
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Show resolved
Hide resolved
joperezr
approved these changes
Apr 18, 2022
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
When a lazy loop has completed iterations but then ends up failing, and the thing it's looping around has no backtracking constructs, we're incorrectly leaving some state associated with the loop on the backtracking stack.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a lazy loop has completed iterations but then ends up failing, and the thing it's looping around has no backtracking constructs, we're incorrectly leaving some state associated with the loop on the backtracking stack. That matters if something earlier in the expression will backtrack and pop associated state from the stack, as it could read the lazy loop's leftover state instead of its own.