Add more diagnostics to LookupProperty (more diagnostics to flaky tests) #68281
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsContributes to: #67816 Seems there was more asserts in LookupProperty I missed last time because AggressiveInlining which caused the stack trace to skip the correct method name
|
krwq
changed the title
| // No cached item was found. Try the main dictionary which has all of the properties. | ||
| Debug.Assert(PropertyCache != null); | ||
| #if DEBUG | ||
| if (PropertyCache == null) |
There was a problem hiding this comment.
IIRC this can only happen during initialization races?
There was a problem hiding this comment.
I think so but I'm not sure how yet, hopefully the DebugInfo will shed some light on the "how"
|
The failure |
…ts) (dotnet#68281) * add more diagnostics to LookupProperty flaky tests * Fix nullability issue on Release build
ghost
locked as resolved and limited conversation to collaborators
2 participants
Contributes to: #67816
Seems there was more asserts in LookupProperty I missed last time because AggressiveInlining which caused the stack trace to skip the correct method name