Skip to content

Conversation

@TanayParikh
Copy link
Contributor

…or SOD

Merges into #68241 (or main if #68241 is merged).

Requires dotnet/performance#2387. Would like to clarify if we should be using a mauimaccatalyst scenario for MacCatalyst or using the ios scenario is sufficient? Details.

For: dotnet/maui#2531

@ghost
Copy link

ghost commented Apr 20, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@LoopedBard3
Copy link
Member

Just using the iOS scenario should be sufficient. The MacCatalyst is basically a remnant from when we were setting up the iOS flow but running into iOS specific issues.

@TanayParikh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@LoopedBard3
Copy link
Member

The specific pipeline we want to test this in is dotnet-runtime-perf but idk if that is one of the available options.

@TanayParikh
Copy link
Contributor Author

I believe it's just skipping a bunch of checks as the target branch is #68241 instead of main. Let's get #68241 merged first and we can take care of this thereafter.

@TanayParikh
Copy link
Contributor Author

this in is dotnet-runtime-perf

Can you please point me to that pipeline, I'm not seeing it in azdo

@LoopedBard3
Copy link
Member

I sent you a DM

@TanayParikh TanayParikh merged commit 6278275 into taparik/mauiBlazorAndroidAPK Apr 20, 2022
@TanayParikh TanayParikh deleted the taparik/mauiBlazorIOSMacCatalyst branch April 20, 2022 23:14
@DrewScoggins
Copy link
Member

Hi @TanayParikh this PR was actually made against one of your branches and not against main. Can you make another PR against the main branch so we can merge it and start to actually get results?

@TanayParikh
Copy link
Contributor Author

Can you make another PR against the main branch so we can merge it and start to actually get results?

The iOS & Mac Catalyst bits are being handled via #68685. That PR is currently blocked on some infra issues.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants