Skip to content

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Apr 25, 2022

Refactoring of getProperties process on the debugger. Original refactoring branch: https://github.com/radical/runtime/tree/322a4fff21787cfc1a62a384414a63eea31eb093.
Fixes accessibility level sorting #63082 and closes the PR with old approach: #63339.
Changes:

  • Moving all the functions connected with fetching object's (object / valuetype) members into a separate, static class to narrow down SdbHelper responsibilities.
  • Creating GetMembersResult that is holding object's members sorted by accessibility.
  • Moving ValueTypeClass into a separate file o shorten SdbHelper.cs.
  • For sorting: more complex tests with inheritance instead of only string-based.
  • For Browsable: adding tests for non-static structures, adding null member and Enum and Class members.

What is not covered:

@ilonatommy ilonatommy requested a review from radical April 25, 2022 11:28
@ilonatommy ilonatommy requested a review from marek-safar as a code owner April 25, 2022 11:28
@ilonatommy ilonatommy self-assigned this Apr 25, 2022
@ghost ghost added the area-Debugger-mono label Apr 25, 2022
@ghost
Copy link

ghost commented Apr 25, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Refactoring of getProperties process on the debugger. Original refactoring branch: https://github.com/radical/runtime/tree/322a4fff21787cfc1a62a384414a63eea31eb093.
Fixes accessibility level sorting #63082 and closes the PR with old approach: #63339.
Changes:

  • Moving all the functions connected with fetching object's (object / valuetype) members into a separate, static class to narrow down SdbHelper responsibilities.
  • Creating GetMembersResult that is holding object's members sorted by accessibility.
  • Moving ValueTypeClass into a separate file o shorten SdbHelper.cs.
  • For sorting: more complex tests with inheritance instead of only string-based.

What is not covered:

Author: ilonatommy
Assignees: ilonatommy
Labels:

area-Debugger-mono

Milestone: -

@ilonatommy ilonatommy added the arch-wasm WebAssembly architecture label Apr 25, 2022
@ilonatommy ilonatommy changed the title [wasm][debugger] Rafactor of [wasm][debugger] Rafactor of getProperties mechanism Apr 25, 2022
@thaystg thaystg changed the title [wasm][debugger] Rafactor of getProperties mechanism [wasm][debugger] Refactor of getProperties mechanism Apr 26, 2022
@ilonatommy
Copy link
Member Author

/azp run runtime-staging

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

ilonatommy commented May 4, 2022

DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsWithVariableParms that failed due to timeout in pipeline staging is passing locally.

@ilonatommy ilonatommy requested a review from thaystg May 4, 2022 15:49
@ilonatommy ilonatommy merged commit 418fb2d into dotnet:main May 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Debugger-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants