regenerate networking ref assemblies #68630
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is related to #68189. It seems like we hand-edit the ref assembly files and/or the tool generating them changed. Ideally, this is really no-op with exception of SslClientHelloInfo that was missing the magic _dummy fields. This was generated with Note that I also tried to do it for HTTP but it generated ref that broke the build. I'll try to investigate separately. @@ -699,10 +686,10 @@ public partial class MediaTypeHeaderValue : System.ICloneable
public override int GetHashCode() { throw null; }
public static System.Net.Http.Headers.MediaTypeHeaderValue Parse(string? input) { throw null; }
- object System.ICloneable.Clone() { throw null; }
+ object? System.ICloneable.Clone() { throw null; }
public override string ToString() { throw null; }
|
ghost
added
the
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
| public override void Write(System.ReadOnlySpan<byte> buffer) { } | ||
| public override System.Threading.Tasks.Task WriteAsync(byte[] buffer, int offset, int count, System.Threading.CancellationToken cancellationToken) { throw null; } | ||
| public override System.Threading.Tasks.ValueTask WriteAsync(System.ReadOnlyMemory<byte> buffer, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; } | ||
| public override System.Threading.Tasks.ValueTask WriteAsync(System.ReadOnlyMemory<byte> buffer, System.Threading.CancellationToken cancellationToken) { throw null; } |
There was a problem hiding this comment.
fixed. It seems like the overload with array does not have default while the ReadOnlyMemor does. I don't know if that is oversight or intention. Should we change it? (may be separate PR as that would be perhaps functional change.
There was a problem hiding this comment.
the overload with array does not have default
It is intentional. For arrays, there are two different ReadAsync methods: One that takes CancellationToken and second one that does not take CancellationToken (inherited from base class).
| public readonly partial struct SslClientHelloInfo | ||
| { | ||
| private readonly object _dummy; | ||
| private readonly int _dummyPrimitive; |
There was a problem hiding this comment.
Note this could cause some existing compiling code to stop compiling. (But we should still fix it.)
4 participants
This is related to #68189. It seems like we hand-edit the ref assembly files and/or the tool generating them changed. Ideally, this is really no-op with exception of SslClientHelloInfo that was missing the magic _dummy fields.
This was generated with
msbuild /t:GenerateReferenceAssemblySourceWith this, adding new API and generating reference should just show the new change instead of this big diff.
Note that I also tried to do it for HTTP but it generated ref that broke the build. I'll try to investigate separately.