[wasm] Migrate rest of the JS interop functions to out params

[maraf]

A follow up on the #65994.

Migrate rest of the JS interop functions to out params instead of return.

• mono_wasm_invoke_js_with_args
• mono_wasm_cancel_promise
• mono_wasm_compile_function

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

A follow up on the #65994.

Migrate rest of the JS interop functions to out params instead of return.

• mono_wasm_invoke_js_with_args
• mono_wasm_cancel_promise
• mono_wasm_compile_function

Author:	maraf
Assignees:	maraf
Labels:	arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:	7.0.0

[maraf]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pavelsavara]

@kg please have look as well.

[kg]

Any icalls we change the signature of like these need to have their name changed, because any third party callers (like blazor, uno etc) will crash or corrupt the heap by passing the wrong number of arguments (or reading a return value that isn't there). The convention I selected is a 'Ref' suffix at the end of the name for C#/C methods, and for JS methods either 'ref' (if they take a MonoObjectRef) or 'root' (if they take a WasmRoot)

[kg]

Thanks for doing the work of spotting these issues and updating the code!

[maraf]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[maraf]

Any icalls we change the signature of like these need to have their name changed, because any third party callers (like blazor, uno etc) will crash or corrupt the heap by passing the wrong number of arguments (or reading a return value that isn't there). The convention I selected is a 'Ref' suffix at the end of the name for C#/C methods, and for JS methods either 'ref' (if they take a MonoObjectRef) or 'root' (if they take a WasmRoot)

Thanks! Now I see it in your PR, I should have read it before.