CoreRT to NativeAOT renames #68950
CoreRT to NativeAOT renames #68950
Conversation
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-meta Issue Detailsnull
|
|
This is the remaining cleanup for #68151 (comment) . Majority of remaining instances are links to archived issues that does not make sense to cleanup. |
jkotas
force-pushed
the
corert
branch
2 times, most recently
from
fa15f9b to
bc9931e
Compare
| @@ -84,8 +84,7 @@ internal sealed unsafe class OverlappedData | |||
| } | |||
| } | |||
|
|
|||
| //CORERT: NativeOverlapped* pNativeOverlapped = (NativeOverlapped*)Interop.MemAlloc((UIntPtr)(sizeof(NativeOverlapped) + sizeof(GCHandle))); | |||
| NativeOverlapped* pNativeOverlapped = (NativeOverlapped*)Marshal.AllocHGlobal((IntPtr)(sizeof(NativeOverlapped) + sizeof(GCHandle))); | |||
| NativeOverlapped* pNativeOverlapped = (NativeOverlapped*)NativeMemory.Alloc((nuint)(sizeof(NativeOverlapped) + sizeof(GCHandle))); | |||
There was a problem hiding this comment.
I have converted several other places that used Marshal.AllocHGlobal to NativeMemory.Alloc while I was on it.
| // Workaround for https://github.com/dotnet/runtime/issues/4731. | ||
| // When that's fixed, a [ThreadStatic] Stack should be added back to AllocFreeConcurrentStack<T>. |
There was a problem hiding this comment.
This bug has been fixed a long time ago. I have kept the workaround for netstandard builds.
| @@ -30,10 +30,6 @@ public partial class Exception | |||
|
|
|||
| private static string? SerializationWatsonBuckets => null; | |||
|
|
|||
| // WARNING: We allow diagnostic tools to directly inspect these three members (_message, _innerException and _HResult) | |||
There was a problem hiding this comment.
Delete these comments from everywhere. They were specific to .NET Native for UWP debugger that we do not care about anymore.
| @@ -145,8 +145,6 @@ class ICodeManager | |||
| PTR_PTR_VOID * ppvRetAddrLocation, // out | |||
| GCRefKind * pRetValueKind) = 0; // out | |||
|
|
|||
| virtual void UnsynchronizedHijackMethodLoops(MethodInfo * pMethodInfo) = 0; | |||
There was a problem hiding this comment.
This was specific to .NET Native for UWP. We do not need it anymore.
| @@ -13,20 +13,13 @@ | |||
| a target called ComputeFilesToPublish which produces the ItemGroup | |||
| ResolvedFileToPublish based on the inputs of @(IntermediateAssembly) | |||
| and @(ResolvedAssembliesToPublish). We modify those two item groups | |||
| to control what gets published after CoreRT optimizes the application. | |||
|
|
|||
| For .NET Core 3.0: | |||
There was a problem hiding this comment.
Deleting support for older .NET SDKs. We support .NET 6+ SDK only.
src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets
Show resolved
Hide resolved
2 participants
No description provided.