Skip to content

Conversation

@steveharter
Copy link
Contributor

As a follow-up to #67917, explicitly support testing of both emit-based and interpreter-based invoke.

No functional changes made to the Release build. The invoke-based tests will run twice, and thus be indirectly tested under both emit and interpreter.

The Checked and Debug runtime builds however support passing in 2 new binding flags to use either the emit or interpreter-based invoke. These do not actually change the public System.Reflection.BindingFlags enum but do apply a soft reservation on that enum for those 2 values to support these test scenarios in an explicit and stable manner.

@steveharter steveharter added area-System.Reflection test-enhancement Improvements of test source code labels May 9, 2022
@steveharter steveharter added this to the 7.0.0 milestone May 9, 2022
@steveharter steveharter self-assigned this May 9, 2022
@ghost
Copy link

ghost commented May 9, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

As a follow-up to #67917, explicitly support testing of both emit-based and interpreter-based invoke.

No functional changes made to the Release build. The invoke-based tests will run twice, and thus be indirectly tested under both emit and interpreter.

The Checked and Debug runtime builds however support passing in 2 new binding flags to use either the emit or interpreter-based invoke. These do not actually change the public System.Reflection.BindingFlags enum but do apply a soft reservation on that enum for those 2 values to support these test scenarios in an explicit and stable manner.

Author: steveharter
Assignees: steveharter
Labels:

area-System.Reflection, test-enhancement

Milestone: 7.0.0

@steveharter steveharter force-pushed the InvokeTest branch 3 times, most recently from bdc5fc8 to 1f99dbc Compare May 10, 2022 19:49
@steveharter
Copy link
Contributor Author

Closing; taking a different approach using context switches.

@steveharter steveharter closed this Jun 1, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2022
@steveharter steveharter deleted the InvokeTest branch August 18, 2023 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Reflection test-enhancement Improvements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant