Skip to content

Conversation

@wfurt
Copy link
Member

@wfurt wfurt commented May 12, 2022

contributes to #37150.

We will throw

System.Net.Sockets.SocketException (00000001, 11): Resource temporarily unavailable
   at System.Net.Dns.GetHostEntryOrAddressesCore(String hostName, Boolean justAddresses, AddressFamily addressFamily, Int64 startingTimestamp) in /home/furt/github/wfurt-runtime/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 393
   at System.Net.Dns.GetHostAddressesCore(String hostName, AddressFamily addressFamily, Int64 startingTimestamp) in /home/furt/github/wfurt-runtime/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 374
   at System.Net.Dns.GetHostAddresses(String hostNameOrAddress, AddressFamily family) in /home/furt/github/wfurt-runtime/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 208
   at System.Net.Dns.GetHostAddresses(String hostNameOrAddress) in /home/furt/github/wfurt-runtime/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 180

instead of

System.Net.Internals.SocketExceptionFactory+ExtendedSocketException (00000001, 11): Resource temporarily unavailable
   at System.Net.Dns.GetHostEntryOrAddressesCore(String hostName, Boolean justAddresses, AddressFamily addressFamily, ValueStopwatch stopwatch)
   at System.Net.Dns.GetHostAddresses(String hostNameOrAddress, AddressFamily family)

The System.Net.Internals.SocketExceptionFactory is derived type from SocketException. This is probably breaking change but I'm not sure what is likelihood that somebody depends on the current Internals.SocketExceptionFactory
This should be back to what .NET Framework did.

This is part of #68918.
Socket change is waiting for #69266

@wfurt wfurt requested review from a team and stephentoub May 12, 2022 18:31
@wfurt wfurt self-assigned this May 12, 2022
@ghost
Copy link

ghost commented May 12, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

contributes to #37150.

We will throw

System.Net.Sockets.SocketException (00000001, 11): Resource temporarily unavailable
   at System.Net.Dns.GetHostEntryOrAddressesCore(String hostName, Boolean justAddresses, AddressFamily addressFamily, Int64 startingTimestamp) in /home/furt/github/wfurt-runtime/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 393
   at System.Net.Dns.GetHostAddressesCore(String hostName, AddressFamily addressFamily, Int64 startingTimestamp) in /home/furt/github/wfurt-runtime/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 374
   at System.Net.Dns.GetHostAddresses(String hostNameOrAddress, AddressFamily family) in /home/furt/github/wfurt-runtime/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 208
   at System.Net.Dns.GetHostAddresses(String hostNameOrAddress) in /home/furt/github/wfurt-runtime/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 180

instead of

System.Net.Internals.SocketExceptionFactory+ExtendedSocketException (00000001, 11): Resource temporarily unavailable
   at System.Net.Dns.GetHostEntryOrAddressesCore(String hostName, Boolean justAddresses, AddressFamily addressFamily, ValueStopwatch stopwatch)
   at System.Net.Dns.GetHostAddresses(String hostNameOrAddress, AddressFamily family)

The System.Net.Internals.SocketExceptionFactory is derived type from SocketException. This is probably breaking change but I'm not sure what is likelihood that somebody depends on the current Internals.SocketExceptionFactory
This should be back to what .NET Framework did.

This is part of #68918.
Socket change is waiting for #69266

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net

Milestone: -

Copy link
Contributor

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wfurt wfurt merged commit bc33b0b into dotnet:main May 16, 2022
@wfurt wfurt deleted the socketException2 branch May 16, 2022 20:44
@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants