Skip to content

Fix for GetMemberWithSameMetadataDefinitionAs#69284

Merged
jkotas merged 6 commits intodotnet:mainfrom
LakshanF:AotReflectionBugFix2
May 17, 2022
Merged

Fix for GetMemberWithSameMetadataDefinitionAs#69284
jkotas merged 6 commits intodotnet:mainfrom
LakshanF:AotReflectionBugFix2

Conversation

@LakshanF
Copy link
Copy Markdown
Contributor

@LakshanF LakshanF commented May 12, 2022

Fixes #67533.

@LakshanF LakshanF marked this pull request as draft May 12, 2022 23:27
@ghost ghost assigned LakshanF May 12, 2022
@ghost
Copy link
Copy Markdown

ghost commented May 12, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Exploratory fix to assess the reflection library testing for native aot

Author: LakshanF
Assignees: -
Labels:

area-System.Reflection

Milestone: -

@LakshanF LakshanF marked this pull request as ready for review May 15, 2022 21:52
@LakshanF LakshanF changed the title Test fix for GetMemberWithSameMetadataDefinitionAs Fix for GetMemberWithSameMetadataDefinitionAs May 15, 2022
@LakshanF LakshanF requested a review from jkotas May 16, 2022 15:08
Comment thread eng/pipelines/runtime.yml Outdated
@LakshanF
Copy link
Copy Markdown
Contributor Author

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@LakshanF
Copy link
Copy Markdown
Contributor Author

/AzurePipelines list

@azure-pipelines
Copy link
Copy Markdown

@LakshanF
Copy link
Copy Markdown
Contributor Author

/azp run runtime

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines failed to run 1 pipeline(s).

@LakshanF LakshanF force-pushed the AotReflectionBugFix2 branch from 371e4f3 to e6fb4f9 Compare May 16, 2022 23:54
Copy link
Copy Markdown
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit 3f0c2cc into dotnet:main May 17, 2022
@LakshanF LakshanF deleted the AotReflectionBugFix2 branch May 17, 2022 14:58
@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetMemberWithSameMetadataDefinitionAs returns incorrect declaring type

3 participants