Handle multiple incoming connection at the beginning of Http3LoopbackConnection use #69453
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #69387. This PR makes sure the The Http functional tests were run in a tight loop and the original test failure was not observed.
|
|
cc: @ManickaP |
|
Was the problem that not all unidirectional streams were the one and only control stream? |
CarnaViire
left a comment
CarnaViire
left a comment
There was a problem hiding this comment.
In general LGTM, but the only question is whether any synchronization needed over _delayedStreams access... can AcceptRequestStreamAsync ever be called concurrently? it feels like it might be...
No, the problem was that client started multiple requests and it happened that two (or more) request streams arrived before the control stream. |
It does not seem that we are accepting multiple requests concurrently in any test. There are other parts of the simple loopback server that were not thread safe before (such as setting the |
CarnaViire
left a comment
CarnaViire
left a comment
There was a problem hiding this comment.
Ok. If Http3LoopbackConnection is not thread-safe in general, I'm fine with this.
LGTM. Thanks!
4 participants
Fixes #69387.
This PR makes sure the
Http3LoopbackConnectionused in tests does not choke on multiple simultaneous requests from a client, when two or more request streams are accepted before the control stream.The Http functional tests were run in a tight loop and the original test failure was not observed.