Fix IsSupported guard check for use of Ssse3.Shuffle in Span.Reverse #69623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were checking for SSE2 support and then using SSSE3 instructions. Fixes dotnet#68880.
ghost
added
the
area-CodeGen-coreclr
Member
Author
stephentoub
approved these changes
May 20, 2022
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWe were checking for SSE2 support and then using SSSE3 instructions. Fixes #68880.
|
tannergooding
approved these changes
May 20, 2022
Member
|
@AndyAyersMS thank you for providing the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking for SSE2 support and then using SSSE3 instructions.
Fixes #68880.