[mono] Fix diamond pattern encountered with static virtual interface methods #69738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interface call Small refactoring to avoid duplicated code
…al interface call
From IL, it is possible to change the access modifier when overriding a method. In such case we need to check the accessibility of the IL method and not the one that we resolve from the constrained class.
BrzVlad
requested review from
SamMonoRT,
lambdageek,
thaystg and
vargaz
as code owners
ghost
added
the
trylek
approved these changes
May 24, 2022
Member
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
I don't really consider myself a Mono expert but to my limited knowledge this looks good, thank you!
Member
Author
|
The test case from the CoreCLR PR might suffer further additions so keeping this on hold until then. |
Member
Author
|
This still passes the latest version of the testcase, so all good. |
Contributor
|
The JIT changes look ok to me. |
Member
|
/azp run runtime-wasm lgtm |
|
No pipelines are associated with this pull request. |
Member
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for this is added in PR #66887