Change dispenser policy for RuntimeAssembly to ReuseAlways #69937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the policy used by all other runtime flavors. Fixes dotnet#69743
ghost
added
the
Member
Author
|
cc @dotnet/ilc-contrib |
MichalStrehovsky
approved these changes
May 30, 2022
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
My only concern/observation is that RuntimeAssembly has a couple caches on it (e.g. type name -> System.Type) that will never be collected now (they would have been collected when the assembly is collected). Not sure how that maps to caching policies on the CLR-JIT side.
I guess we'll unify these as we unify the reflection stacks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the policy used by all other runtime flavors.
Fixes #69743