Delete SegmentCommandLine from utilcode #71111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned
jkotas
force-pushed
the
SegmentCommandLine
branch
from
27132c5 to
cb32415
Compare
jkotas
commented
Jun 22, 2022
src/coreclr/ildasm/windasm.cpp
Outdated
Member
Author
There was a problem hiding this comment.
Instead of doing all these complicated conversions, we just use the argc+argv from the standard C main or wmain methods.
jkotas
force-pushed
the
SegmentCommandLine
branch
from
cb32415 to
85f16ea
Compare
Member
Author
|
Test failure is #70969 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.