Bump Newtonsoft.Json from 12.0.3 to 13.0.1 in /src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer #71180

dependabot · 2022-06-23T02:17:48Z

Bumps Newtonsoft.Json from 12.0.3 to 13.0.1.

Release notes

Sourced from Newtonsoft.Json's releases.

13.0.1

New feature - Add JsonSelectSettings with configuration for a regex timeout

Change - Remove portable assemblies from NuGet package

Change - JsonReader and JsonSerializer MaxDepth defaults to 64

Fix - Fixed throwing missing member error on ignored fields

Fix - Fixed various nullable annotations

Fix - Fixed annotations not being copied when tokens are cloned

Fix - Fixed naming strategy not being used when deserializing dictionary enum keys

Fix - Fixed serializing nullable struct dictionaries

Fix - Fixed JsonWriter.WriteToken to allow null with string token

Fix - Fixed missing error when deserializing JToken with a contract type mismatch

Fix - Fixed JTokenWriter when writing comment to an object

Commits

ae9fe44 Remove compiler package and update sourcelink (#2498)
8ef6621 Remove prerelease for 13.0.1
11331f5 Update SDK to 5.0.200 (#2495)
c7e8abc Update to 13.0.1-beta2
1745d7c Fix JTokenWriter when writing comment to an object (#2493)
583eb12 Fix missing error when deserializing JToken with a contract type mismatch (#2...
b6dc05b Change MaxDepth default to 64 (#2473)
15525f1 Fix JsonWriter.WriteToken to allow null with string token (#2472)
926d2f0 Enable embed untracked sources (#2471)
0a56633 Fixes #2372 - variable typos (#2465)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

ghost · 2022-06-23T02:18:01Z

Tagging subscribers to this area: @dotnet/area-dependencymodel
See info in area-owners.md if you want to be subscribed.

Issue Details

Bumps Newtonsoft.Json from 12.0.3 to 13.0.1.

Release notes

Sourced from Newtonsoft.Json's releases.

13.0.1

New feature - Add JsonSelectSettings with configuration for a regex timeout

Change - Remove portable assemblies from NuGet package

Change - JsonReader and JsonSerializer MaxDepth defaults to 64

Fix - Fixed throwing missing member error on ignored fields

Fix - Fixed various nullable annotations

Fix - Fixed annotations not being copied when tokens are cloned

Fix - Fixed naming strategy not being used when deserializing dictionary enum keys

Fix - Fixed serializing nullable struct dictionaries

Fix - Fixed JsonWriter.WriteToken to allow null with string token

Fix - Fixed missing error when deserializing JToken with a contract type mismatch

Fix - Fixed JTokenWriter when writing comment to an object

Commits

ae9fe44 Remove compiler package and update sourcelink (#2498)
8ef6621 Remove prerelease for 13.0.1
11331f5 Update SDK to 5.0.200 (#2495)
c7e8abc Update to 13.0.1-beta2
1745d7c Fix JTokenWriter when writing comment to an object (#2493)
583eb12 Fix missing error when deserializing JToken with a contract type mismatch (#2...
b6dc05b Change MaxDepth default to 64 (#2473)
15525f1 Fix JsonWriter.WriteToken to allow null with string token (#2472)
926d2f0 Enable embed untracked sources (#2471)
0a56633 Fixes #2372 - variable typos (#2465)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Author:	dependabot[bot]
Assignees:	-
Labels:	`area-DependencyModel`, `.NET`
Milestone:	-

akoeplinger · 2022-06-27T12:31:26Z

The failures in runtime (Build Browser wasm Linux Release LibraryTests) look related:

Application startup exception: System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
Could not load file or assembly 'Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The system cannot find the file specified.

   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.Assembly.GetTypes()
   at Microsoft.DotNet.XHarness.CLI.CommandArguments.TypeFromAssemblyArgument`1.GetLoadedTypes()+MoveNext() in /_/src/Microsoft.DotNet.XHarness.CLI/CommandArguments/Arguments/TypeFromAssemblyArgument.cs:line 29
   at Microsoft.DotNet.XHarness.CLI.Commands.WebServer.<>c__DisplayClass0_0.<Start>b__9(TestWebServerOptions options) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WebServer.cs:line 60
   at Microsoft.Extensions.Options.OptionsFactory`1.Create(String name)
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
   at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
   at System.Lazy`1.CreateValue()
   at Microsoft.Extensions.Options.OptionsCache`1.GetOrAdd(String name, Func`1 createOptions)
   at Microsoft.DotNet.XHarness.CLI.Commands.WebServer.TestWebServerStartup.Configure(IApplicationBuilder app, IOptionsMonitor`1 optionsAccessor) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WebServer.cs:line 126
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Span`1& arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at Microsoft.AspNetCore.Hosting.ConfigureBuilder.Invoke(Object instance, IApplicationBuilder builder)
   at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
   at Microsoft.AspNetCore.Hosting.WebHost.BuildApplication()

@lewing @radical

ghost · 2022-07-05T21:29:23Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Bumps Newtonsoft.Json from 12.0.3 to 13.0.1.

Release notes

Sourced from Newtonsoft.Json's releases.

13.0.1

New feature - Add JsonSelectSettings with configuration for a regex timeout

Change - Remove portable assemblies from NuGet package

Change - JsonReader and JsonSerializer MaxDepth defaults to 64

Fix - Fixed throwing missing member error on ignored fields

Fix - Fixed various nullable annotations

Fix - Fixed annotations not being copied when tokens are cloned

Fix - Fixed naming strategy not being used when deserializing dictionary enum keys

Fix - Fixed serializing nullable struct dictionaries

Fix - Fixed JsonWriter.WriteToken to allow null with string token

Fix - Fixed missing error when deserializing JToken with a contract type mismatch

Fix - Fixed JTokenWriter when writing comment to an object

Commits

ae9fe44 Remove compiler package and update sourcelink (#2498)
8ef6621 Remove prerelease for 13.0.1
11331f5 Update SDK to 5.0.200 (#2495)
c7e8abc Update to 13.0.1-beta2
1745d7c Fix JTokenWriter when writing comment to an object (#2493)
583eb12 Fix missing error when deserializing JToken with a contract type mismatch (#2...
b6dc05b Change MaxDepth default to 64 (#2473)
15525f1 Fix JsonWriter.WriteToken to allow null with string token (#2472)
926d2f0 Enable embed untracked sources (#2471)
0a56633 Fixes #2372 - variable typos (#2465)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Author:	dependabot[bot]
Assignees:	-
Labels:	`area-System.Net`, `community-contribution`, `.NET`
Milestone:	-

radical · 2022-07-06T01:17:02Z

Why are we updating this version, and only for this specific project? Do we need to update $(NewtonsoftJsonVersion) too?

eng/Versions.props:    <NewtonsoftJsonVersion>12.0.3</NewtonsoftJsonVersion>
eng/testing/xunit/xunit.props:    <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" />
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj:    <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" />

am11 · 2022-07-11T17:35:47Z

Do we need to update $(NewtonsoftJsonVersion) too?

Updated in #71402. The only file I had to revert is NetCoreServer.csproj (in 3a1fd4d) which this PR is updating. It looks like we have some clash with xharness (or a similar dependency) which pulls in older newtonsoft and breaks the build (with the same error / callstack as #71180 (comment)). I didn't investigated it further.

dependabot · 2022-08-02T17:36:01Z

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

MihaZupan · 2022-08-07T22:38:12Z

xharness updated this in dotnet/xharness#930 and dotnet/xharness#932

am11 · 2022-08-07T22:57:15Z

@MihaZupan, it needs dotnet/arcade#9962 (and probably an update from xharness running the updated arcade)

garath · 2022-08-08T21:09:10Z

it needs dotnet/arcade#9962 (and probably an update from xharness running the updated arcade)

Arcade and xharness should be using up-to-date Newtonsoft.Json packages as of last week (earlier for Arcade). Certainly let us know if something looks amiss.

am11 · 2022-08-08T21:26:46Z

Great. I suppose we are waiting for #72934 and #73517.

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/NetCoreServer.csproj

Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@12.0.3...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

…ver/NetCoreServer.csproj Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

dependabot bot added .NET area-DependencyModel labels Jun 23, 2022

ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 23, 2022

stephentoub approved these changes Jun 23, 2022

View reviewed changes

dependabot bot force-pushed the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch from 4af13b3 to 3b9853d Compare June 23, 2022 11:44

maryamariyan added area-System.Net and removed area-DependencyModel labels Jul 5, 2022

am11 mentioned this pull request Jul 13, 2022

Microsoft.DotNet.SignCheckLibrary: Update Newtonsoft.Json reference to dotnet/arcade#9962

Closed

1 task

runfoapp bot mentioned this pull request Jul 27, 2022

System.Net.* cancellation tests fail in CI #72818

Closed

MihaZupan closed this Aug 2, 2022

MihaZupan reopened this Aug 2, 2022

dependabot bot force-pushed the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch from 3b9853d to bcaa385 Compare August 2, 2022 17:36

MihaZupan closed this Aug 7, 2022

dependabot bot deleted the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch August 7, 2022 22:38

MihaZupan restored the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch August 7, 2022 22:38

MihaZupan reopened this Aug 7, 2022

dependabot bot force-pushed the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch from bcaa385 to 7ff4a02 Compare August 7, 2022 22:39

am11 reviewed Aug 8, 2022

View reviewed changes

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/NetCoreServer.csproj Outdated Show resolved Hide resolved

MihaZupan closed this Aug 13, 2022

dependabot bot deleted the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch August 13, 2022 18:42

MihaZupan restored the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch August 13, 2022 18:42

MihaZupan reopened this Aug 13, 2022

dependabot bot force-pushed the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch from 7ff4a02 to f4b8d8a Compare August 13, 2022 18:42

Update src/libraries/Common/tests/System/Net/Prerequisites/NetCoreSer…

bff70c1

…ver/NetCoreServer.csproj Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

MihaZupan approved these changes Aug 15, 2022

View reviewed changes

MihaZupan added this to the 7.0.0 milestone Aug 15, 2022

MihaZupan merged commit 62d1d42 into main Aug 15, 2022

dependabot bot deleted the dependabot/nuget/src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Newtonsoft.Json-13.0.1 branch August 15, 2022 16:06

ghost locked as resolved and limited conversation to collaborators Sep 14, 2022

jeffhandley removed the community-contribution Indicates that the PR has been added by a community member label Jul 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump Newtonsoft.Json from 12.0.3 to 13.0.1 in /src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer #71180

Bump Newtonsoft.Json from 12.0.3 to 13.0.1 in /src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer #71180

Uh oh!

dependabot bot commented on behalf of github Jun 23, 2022 •

edited

Loading

Uh oh!

ghost commented Jun 23, 2022

13.0.1

Uh oh!

akoeplinger commented Jun 27, 2022

Uh oh!

ghost commented Jul 5, 2022

13.0.1

Uh oh!

radical commented Jul 6, 2022

Uh oh!

am11 commented Jul 11, 2022

Uh oh!

dependabot bot commented on behalf of github Aug 2, 2022

Uh oh!

MihaZupan commented Aug 7, 2022

Uh oh!

am11 commented Aug 7, 2022

Uh oh!

garath commented Aug 8, 2022

Uh oh!

am11 commented Aug 8, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Bump Newtonsoft.Json from 12.0.3 to 13.0.1 in /src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer #71180

Bump Newtonsoft.Json from 12.0.3 to 13.0.1 in /src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer #71180

Uh oh!

Conversation

dependabot bot commented on behalf of github Jun 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

13.0.1

Uh oh!

ghost commented Jun 23, 2022

13.0.1

Uh oh!

akoeplinger commented Jun 27, 2022

Uh oh!

ghost commented Jul 5, 2022

13.0.1

Uh oh!

radical commented Jul 6, 2022

Uh oh!

am11 commented Jul 11, 2022

Uh oh!

dependabot bot commented on behalf of github Aug 2, 2022

Uh oh!

MihaZupan commented Aug 7, 2022

Uh oh!

am11 commented Aug 7, 2022

Uh oh!

garath commented Aug 8, 2022

Uh oh!

am11 commented Aug 8, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dependabot bot commented on behalf of github Jun 23, 2022 •

edited

Loading