Enable TYP_STRUCT LCL_VAR/LCL_FLD call args on ARM64
#71328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-CodeGen-coreclr
SingleAccretion
changed the title
TYP_STRUCT LCL_VAR/LCL_FLD call args on LATYP_STRUCT LCL_VAR/LCL_FLD call args on ARM64
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsNow that we have full codegen support, enable the folding. We are expecting nice diffs as usual.
|
Closed
Q: isn't this actually dead code?
SingleAccretion
force-pushed
the
Struct-LclFld-Args-Arm64-Upstream
branch
from
1b935d6 to
01d7536
Compare
Contributor
Author
|
@dotnet/jit-contrib |
jakobbotsch
approved these changes
Jun 29, 2022
This was referenced Jul 20, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have full codegen support, enable the folding.
Nice diffs as expected.