[QUIC] API QuicConnection (#71783), QuicStream (#71969), QUIC public (#72031) #72106
Conversation
* Listener comment; PreviewFeature attribute * Feedback * QuicConnection new API including compilable implementation * Fixed logging * Fixed S.N.Quic and S.N.Http tests * Options now correspond to the issue * Feedback * Comments, PreviewFeature attribute and RemoteCertificate disposal. * Preview feature attribute is assembly wide * Some typos * Fixed test with certificate * Default values as constants * Event handlers split into methods called via switch expression. * Some more comments * Unified unsafe usage * Fixed some more tests * Cleaned up some exceptions and resource strings. * Feedback * Latest greatest API proposal. * Fixed Http solution * Feedback
ManickaP
requested review from
CarnaViire,
rzikm and
wfurt
and removed request for
rzikm and
wfurt
ghost
assigned
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ManickaP
requested review from
rzikm and
wfurt
and removed request for
CarnaViire
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #71783 to release/7.0-preview7 /cc @ManickaP Customer ImpactSome of the QUIC APIs were finally approved last evening and we were not able to make them in even if the team worked late night. TestingThere are existing RiskLow. The whole library is in preview. And HTTP/3 is still not enabled by default.
|
ManickaP
changed the title
* Quic stream API surface * Fixed test compilation * Fixed http test compilation * HttpLoopbackConnection Dispose -> DisposeAsync * QuicStream implementation * Fixed some tests * Fixed all QUIC and HTTP tests * Fixed exception type for stream closed by connection close * Feedback * Fixed WebSocket.Client test build * Feedback, test fixes * Fixed build on framework and windows * Fixed winhandler test * Swap variable based on order in defining class * Post merge fixes * Feedback and build * Reverted connection state to pass around abort error code * Fixed exception type.
* System.Net.Quic removed from ASP transport package and made part of SDK ref * Removed manual references to System.Net.Quic.csproj
carlossanlop
added
Servicing-approved
|
Approved via email. Will merge once the CI passes. cc @ManickaP |
|
The failing test is #71233, unrelated. It's been also noted on the original PRs into main. |
5 participants
Backport of #71783, #71969 and #72031 to release/7.0-preview7
/cc @ManickaP
Customer Impact
Some of the QUIC APIs were finally approved last evening and we were not able to make them in even if the team worked late night.
They are all QUIC changes and not related or dependent on anything else.
This will allow Kestreal to consume the final API shape and we may be able to get at least some public use.
Testing
There are existing
System.Net.QuicandSystem.Net.Httpfunctional tests.Risk
Low. The whole library is in preview. And HTTP/3 is still not enabled by default.