Skip to content

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Jul 26, 2022

Delete target-specific #ifdefs and unify the associated code.

No diffs as expected.

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Jul 26, 2022
@ghost
Copy link

ghost commented Jul 26, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Delete target-specific #ifdefs and unify the associated code.

No diffs are expected.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review July 27, 2022 12:58
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

@AndyAyersMS
Copy link
Member

Let's get a fresh CI run here.

@AndyAyersMS AndyAyersMS reopened this Aug 26, 2022
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment nit

@AndyAyersMS AndyAyersMS merged commit 02686c0 into dotnet:main Sep 7, 2022
@AndyAyersMS
Copy link
Member

Thanks again for your contribution!

@SingleAccretion SingleAccretion deleted the impReturnInstruction-Cleanup branch September 7, 2022 20:50
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants