WIP: Run tests sequentially by default #73
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Closing in favor of #77 |
Member
|
What was the outcome here? Did it also address the problem? Is coreclr going to have the same issue again when we move to the official xunit and dump the custom runner? |
Member
No, as the plan is to move from the |
Member
|
Ok. |
ghost
locked as resolved and limited conversation to collaborators
DeepakRajendrakumaran
added a commit
to DeepakRajendrakumaran/runtime
that referenced
this pull request
Nov 18, 2021
DeepakRajendrakumaran
added a commit
to DeepakRajendrakumaran/runtime
that referenced
this pull request
Nov 18, 2021
This reverts commit aa510571491075fe35cc0671f52c1d1427bd73c9.
radical
pushed a commit
to radical/runtime
that referenced
this pull request
Jul 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the stock Xunit runner has a parallelism bug
we were previously working around by using a custom version with
Egor's fix. After we migrated CoreCLR to the combined
dotnet/runtime repo and switched over to a common Xunit runner,
this popped up as non-deterministic failures in Linux runs.
Based on Stephen Toub's suggestion I'm proposing to switch
the runner over to run tests sequentially by default - the
perf penalty should be low and in fact this might even make some
of the tests more stable.
Thanks
Tomas