Skip to content

Conversation

@pedrobsaila
Copy link
Contributor

@pedrobsaila pedrobsaila commented Aug 1, 2022

Fixes #60933

I drop retries on PerformanceCounterCategory constructor calls because they seem useless. The constructor throws exception only when (categoryName null or its length = 0) or (machineName null or string empty or contains \) (retries do not change the output)

@ghost ghost added area-System.Diagnostics.PerformanceCounter community-contribution Indicates that the PR has been added by a community member labels Aug 1, 2022
@ghost
Copy link

ghost commented Aug 1, 2022

Tagging subscribers to this area: @dotnet/area-system-diagnostics-performancecounter
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #60933

Author: pedrobsaila
Assignees: -
Labels:

area-System.Diagnostics.PerformanceCounter

Milestone: -

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlossanlop
Copy link
Contributor

Thanks for your contribution!

@carlossanlop carlossanlop merged commit 1222d3e into dotnet:main Aug 17, 2022
@pedrobsaila pedrobsaila deleted the 60933 branch August 17, 2022 18:30
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Diagnostics.PerformanceCounter community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.Diagnostics.Tests.PerformanceCounterTests failed in CI

2 participants