Skip to content

Conversation

@lambdageek
Copy link
Member

in AOT we may not have fields inited if we're using cached class info.

Fixes #73180

@lambdageek
Copy link
Member Author

/azp run runtime-wasm

@ghost
Copy link

ghost commented Aug 1, 2022

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

in AOT we may not have fields inited if we're using cached class info.

Fixes #73180

Author: lambdageek
Assignees: -
Labels:

area-Codegen-Interpreter-mono

Milestone: -

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek
Copy link
Member Author

@lambdageek
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek
Copy link
Member Author

Adding initializations, and asserting that the class isn't marked with a failure didn't help. I guess the stack trace could be misleading. Need to try and repro locally.

@lambdageek lambdageek marked this pull request as draft August 2, 2022 13:44
@lambdageek
Copy link
Member Author

Trying to revert #70649 to see if that resolves it

@lambdageek
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek
Copy link
Member Author

Reverting #70649 fixes the crash

@lambdageek lambdageek changed the title [interp] Init Span/ReadOnlySpan fields in get_Item/get_Length intrinsics Revert "[mono][interp] Improve tiering performance (dotnet#70649)" Aug 2, 2022
@lambdageek lambdageek marked this pull request as ready for review August 2, 2022 17:11
@lambdageek
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek
Copy link
Member Author

Closing in favor of #73264

@lambdageek lambdageek closed this Aug 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm] System.Xml.XmlSerializer.Tests crashing with AOT

2 participants