-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Revert "[mono][interp] Improve tiering performance (dotnet#70649)" #73187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run runtime-wasm |
|
Tagging subscribers to this area: @BrzVlad Issue Detailsin AOT we may not have fields inited if we're using cached class info. Fixes #73180
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Nope, that wasn't enough. still failing https://helix.dot.net/api/2019-06-17/jobs/75f26afc-7835-4238-9f6c-1006f01fba71/workitems/normal-System.Xml.XmlSerializer.Tests/console |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Adding initializations, and asserting that the class isn't marked with a failure didn't help. I guess the stack trace could be misleading. Need to try and repro locally. |
|
Trying to revert #70649 to see if that resolves it |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit 01444f7.
c8618ae to
13513b5
Compare
|
Reverting #70649 fixes the crash |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Closing in favor of #73264 |
in AOT we may not have fields inited if we're using cached class info.
Fixes #73180